From e02da2290619553f6fba67d8584cb1a49414bc87 Mon Sep 17 00:00:00 2001 From: "Wladimir J. van der Laan" Date: Thu, 10 Oct 2019 11:00:28 +0200 Subject: [PATCH 1/2] doc: Add CODEOWNERS file Describes maintainers. See https://help.github.com/en/articles/about-code-owners for syntax. Ref #17094. --- CODEOWNERS | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 CODEOWNERS diff --git a/CODEOWNERS b/CODEOWNERS new file mode 100644 index 0000000000..010ef48bb2 --- /dev/null +++ b/CODEOWNERS @@ -0,0 +1,25 @@ +# Nonspecific maintainers +# @laanwj +# @sipa +# @fanquake + +# Build system maintainer +/configure.ac @theuni +/build-aux/ @theuni +/depends/ @theuni +*.am @theuni +Makefile.* @theuni + +# Test framework maintainer +/src/test/ @marcofalke +/test/ @marcofalke +/ci/ @marcofalke + +# GUI maintainer +/src/qt/ @jonasschnelli + +# Wallet maintainer +/src/wallet/ @meshcollider + +# MSVC build system maintainer +/build_msvc/ @sipsorcery From a06eb03ded1a70879db86a03c2d6831e2ed75f62 Mon Sep 17 00:00:00 2001 From: Adam Jonas Date: Sat, 2 May 2020 20:34:44 -0400 Subject: [PATCH 2/2] doc: Add comments and additional reviewers to CODEOWNERS file --- CODEOWNERS | 145 ++++++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 128 insertions(+), 17 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 010ef48bb2..24a80fb35d 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,25 +1,136 @@ -# Nonspecific maintainers +# ============================================================================== +# Bitcoin Core CODEOWNERS +# ============================================================================== + +# Configuration of code ownership and review approvals for the bitcoin/bitcoin +# repo. + +# Order is important; the last matching pattern takes the most precedence. +# More info on how this file works can be found at: +# https://help.github.com/articles/about-codeowners/ + +# This file is called CODEOWNERS because it is a magic file for GitHub to +# automatically suggest reviewers. In this project's case, the names below +# should be thought of as code reviewers rather than owners. Regular +# contributors are free to add their names to specific directories or files +# provided that they are willing to provide a review when automatically +# assigned. + +# Absence from this list should not be interpreted as a discouragement to +# review a pull request. Peer review is always welcome and is a critical +# component of the progress of the codebase. Information on peer review +# guidelines can be found in the CONTRIBUTING.md doc. + + +# Maintainers # @laanwj # @sipa # @fanquake +# @jonasschnelli +# @marcofalke +# @meshcollider + +# Docs +/doc/*[a-zA-Z-].md @harding +/doc/Doxyfile.in @fanquake +/doc/REST-interface.md @jonasschnelli +/doc/benchmarking.md @ariard +/doc/bitcoin-conf.md @hebasto +/doc/build-freebsd.md @fanquake +/doc/build-netbsd.md @fanquake +/doc/build-openbsd.md @laanwj +/doc/build-osx.md @fanquake +/doc/build-unix.md @laanwj +/doc/build-windows.md @sipsorcery +/doc/dependencies.md @fanquake +/doc/developer-notes.md @laanwj +/doc/files.md @hebasto +/doc/gitian-building.md @laanwj +/doc/reduce-memory.md @fanquake +/doc/reduce-traffic.md @jonasschnelli +/doc/release-process.md @laanwj +/doc/translation_strings_policy.md @laanwj + +# Build aux +/build-aux/m4/bitcoin_qt.m4 @hebasto + +# MSVC build system +/build_msvc/ @sipsorcery + +# Settings +/src/util/settings.* @ryanofsky + +# Fuzzing +/src/test/fuzz/ @practicalswift +/doc/fuzzing.md @practicalswift + +# Test framework +/test/functional/mempool_updatefromblock.py @hebasto +/test/functional/feature_asmap.py @jonatack +/test/functional/interface_bitcoin_cli.py @jonatack +/test/functional/tool_wallet.py @jonatack + +# Translations +/src/util/translation.h @hebasto + +# Dev Tools +/contrib/devtools/security-check.py @fanquake +/contrib/devtools/test-security-check.py @fanquake +/contrib/devtools/symbol-check.py @fanquake + +# Gitian/Guix +/contrib/gitian-build.py @hebasto +/contrib/guix/ @dongcarl + +# Compatibility +/src/compat/glibc_* @fanquake + +# GUI +/src/qt/forms/ @hebasto + +# Wallet +/src/wallet/ @achow101 + +# CLI +/src/bitcoin-cli.cpp @jonatack + +# Coinstats +/src/node/coinstats.* @fjahr + +# Index +/src/index/ @fjahr + +# Descriptors +*descriptor* @achow101 @sipa + +# Interfaces +/src/interfaces/ @ryanofsky + +# DB +/src/txdb.* @jamesob +/src/dbwrapper.* @jamesob -# Build system maintainer -/configure.ac @theuni -/build-aux/ @theuni -/depends/ @theuni -*.am @theuni -Makefile.* @theuni +# Scripts/Linter +*.sh @practicalswift +/test/lint/ @practicalswift +/test/lint/lint-shell.sh @hebasto -# Test framework maintainer -/src/test/ @marcofalke -/test/ @marcofalke -/ci/ @marcofalke +# Bech32 +/src/bech32.* @sipa +/src/bench/bech32.* @sipa -# GUI maintainer -/src/qt/ @jonasschnelli +# PSBT +/src/psbt* @achow101 +/src/node/psbt* @achow101 +/doc/psbt.md @achow101 -# Wallet maintainer -/src/wallet/ @meshcollider +# P2P +/src/net_processing.* @sipa +/src/protocol.* @sipa -# MSVC build system maintainer -/build_msvc/ @sipsorcery +# Consensus +/src/coins.* @sipa @jamesob +/src/script/script.* @sipa +/src/script/interpreter.* @sipa +/src/validation.* @sipa +/src/consensus/ @sipa