Skip to content

Commit

Permalink
Pin CircleCI container to cimg/node:16.8 until 16.9.1 available.
Browse files Browse the repository at this point in the history
Bug nodejs/node#40030 will be fixed in Node.js
v16.9.1: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V16.md#2021-09-10-version-1691-current-richardlau

This bug has been causing frequent spurious test failures for Apollo
Client. A few examples:
https://app.circleci.com/pipelines/github/apollographql/apollo-client/11547/workflows/4027b7e7-b8bd-4cf1-8927-f08921a4c577/jobs/83124
https://app.circleci.com/pipelines/github/apollographql/apollo-client/11571/workflows/3e78ba11-0e51-4f4f-92dd-e732c53716d2/jobs/83167
https://app.circleci.com/pipelines/github/apollographql/apollo-client/11536/workflows/55d29d9f-b4a7-4803-80bb-e3891946960d/jobs/83106

CircleCI ships docker containers for most Node.js versions, but they
haven't shipped a new version for 16.9.1 yet (16.9.0 is the latest). We
will switch back to `cimg/node:16` once that gives us a version greater
than or equal to 16.9.1.
  • Loading branch information
benjamn committed Sep 16, 2021
1 parent 469f995 commit c94e575
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2
jobs:
Filesize:
docker:
- image: circleci/node:16
- image: cimg/node:16.8
steps:
- checkout
- restore_cache:
Expand All @@ -26,7 +26,7 @@ jobs:

Tests:
docker:
- image: circleci/node:16
- image: cimg/node:16.8
steps:
- checkout
- restore_cache:
Expand Down

0 comments on commit c94e575

Please sign in to comment.