Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'errorPolicy' to FetchMoreQueryOptions interface #12298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dlin303
Copy link

@dlin303 dlin303 commented Jan 22, 2025

Adds errorPolicy option to FetchMoreQueryOptions interface to expose errorPolicy functionality on fetchMore to TypeScript.

Fixes: #12297

@apollo-cla
Copy link

@dlin303: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

netlify bot commented Jan 22, 2025

👷 Deploy request for apollo-client-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0b540ea

@svc-apollo-docs
Copy link

svc-apollo-docs commented Jan 22, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 4 changed, 0 removed
* (developer-tools)/react/(latest)/api/link/apollo-link-error.md
* (developer-tools)/react/(latest)/development-testing/schema-driven-testing.mdx
* (developer-tools)/react/(latest)/development-testing/testing.mdx
* graphos/reference/router/telemetry/trace-exporters/jaeger.mdx

Build ID: ee5af6fc772fd083ac81f000

URL: https://www.apollographql.com/docs/deploy-preview/ee5af6fc772fd083ac81f000

Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 0b540ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dlin303 dlin303 force-pushed the fetchMore-add-errorPolicy-type branch from d88db9d to 0b540ea Compare January 22, 2025 21:23
@dlin303
Copy link
Author

dlin303 commented Jan 22, 2025

Not sure why security-scans workflow is failing. It looks like I don't have access in CircleCI to see the actual job or failure.

@jerelmiller
Copy link
Member

@dlin303 don't worry about that one. For some reason that security scan fails on all forked PRs. Thanks for opening the PR! We'll try and get to it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errorPolicy is not defined on FetchMoreQueryOptions interface for fetchMore
4 participants