-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with Vite 3 , Apollo shipping wrong ESM entries #9834
Comments
Sure. |
Actually, this one is not related to #8190. This bug seems to be about apollo shipping wrong ESM entries. See https://github.com/brillout/graphql-apollo_vite-3_bug-2. This may very well break all vite-plugin-ssr Apollo GraphQL users who will want to switch from Vite 2 to Vite 3. |
@brillout Thanks for clarifying, I'll reopen this issue and clarify the title a bit. |
Hello. Any updates on this issue or any idea if a fix is planned for |
Hi @brillout 👋 thanks for following up here. I took a look at https://github.com/brillout/graphql-apollo_vite-3_bug-2 but was seeing some unrelated errors regarding In search of a more minimal reproduction, I found the excellent examples in your vite-plugin-ssr repo :) I was able to get As you know, this example imports from |
Thanks for the PR! Let's see if the test suites goes green and, if yes, then we can close this 👌. |
vite-plugin-ssr's Apollo test suites are green again 🟢. |
Just saw you merged the PR @brillout, thanks for your help here! |
Because of an ESM compatibility problem. Note that a lot of libraries do work with Vite 3, so I'm leaning towards thinking that it's an issue on Apollo GraphQL's side.
Reproduction: https://github.com/brillout/graphql-apollo_vite-3_bug-2.
(I didn't manage to make a more minimal reproduction because of #9833.)
The text was updated successfully, but these errors were encountered: