Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to send custom identifiers with web socket messages #1837

Closed
1 task
designatednerd opened this issue Jun 16, 2021 · 1 comment · Fixed by #1919
Closed
1 task

Add ability to send custom identifiers with web socket messages #1837

designatednerd opened this issue Jun 16, 2021 · 1 comment · Fixed by #1919
Labels
apollo-websockets enhancement Issues outlining new things we want to do or things that will make our lives as devs easier

Comments

@designatednerd
Copy link
Contributor

designatednerd commented Jun 16, 2021

Feature request

The current state of our RequestBodyCreator's interaction with our web socket library's OperationMessage does not allow the user to set an ID on the operation message itself. This limits what can be done with each message since some servers rely on the ID of the operation message being something specific, rather than the current setup which uses the number in the sequence of messages as the ID.

We should add the ability to have the id on OperationMessage have a specified value.

Motivation

This will facilitate supporting servers which require a custom identifier to be passed along with the subscriptions, specifically AWS AppSync subscriptions.

See more extensive discussion here

Outstanding Questions

  • Right now the ID being sent is number in the sequence of messages. It's not 100% clear what's depending on this at the moment, but I suspect there may be some stuff around retries and/or cancellation that might be dealing with this. We will need to identify exactly what's going on here before making this customizable.
@designatednerd designatednerd added enhancement Issues outlining new things we want to do or things that will make our lives as devs easier apollo-websockets labels Jun 16, 2021
@cmcnally-beachbody
Copy link
Contributor

@designatednerd Any plans to to make this update anytime soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apollo-websockets enhancement Issues outlining new things we want to do or things that will make our lives as devs easier
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants