Broken codegen for nested fragments with enum

[tgyhlsb]

Summary

When nesting fragments and enums, the "__fulfilled" set is missing some cases and .asSomething() operators fail.

Version

1.1.3

Steps to reproduce the behavior

Here is a simplified schema needed to reproduce:

fragment ConversationItemFragment on ConversationItem {
    ... on Message {
        ...MessageFragment
    }
    ... on ConversationActivity {
        ...ConversationActivityFragment
    }
}

fragment MessageFragment on Message {
    id
    content {
        ...MessageContentFragment
    }
}

fragment MessageContentFragment on MessageContent {
    ... on TextMessageContent {
        ...TextMessageContentFragment
    }
    ... on ImageMessageContent {
        ...ImageMessageContentFragment
    }
}

fragment TextMessageContentFragment on TextMessageContent {
    text
}

fragment ImageMessageContentFragment on ImageMessageContent {
    url
}

Here is the output of the codegen with:

                        schemaNamespace: "GQL",
                        options: .init(
                            selectionSetInitializers: [
                                .fragment(named: "ConversationItemFragment"),
                                .fragment(named: "MessageFragment"),
                            ],

extension GQL {
  struct ConversationItemFragment: GQL.SelectionSet, Fragment {
    struct AsMessage: GQL.InlineFragment {
      init(
        id: GQL.UUID,
        content: MessageFragment.Content,
      ) {
        self.init(_dataDict: DataDict(data: [
          "__typename": GQL.Objects.Message.typename,
          "id": id,
          "content": content._fieldData,
          "__fulfilled": Set([
            ObjectIdentifier(Self.self),
            ObjectIdentifier(ConversationItemFragment.self),
            ObjectIdentifier(MessageFragment.self)
          ])
        ]))
      }
    }
  }
}


extension GQL {
  struct MessageFragment: GQL.SelectionSet, Fragment {
    struct Content: GQL.SelectionSet {
      struct AsTextMessageContent: GQL.InlineFragment, ApolloAPI.CompositeInlineFragment {
        init(
          text: String
        ) {
          self.init(_dataDict: DataDict(data: [
            "__typename": GQL.Objects.TextMessageContent.typename,
            "text": text,
            "__fulfilled": Set([
              ObjectIdentifier(Self.self),
              ObjectIdentifier(MessageFragment.Content.self),
              ObjectIdentifier(MessageContentFragment.self),
              ObjectIdentifier(TextMessageContentFragment.self)
            ])
          ]))
        }
      }
    }
  }
}

Then when I try to use the generated initializer:

let item = GQL.ConversationItemFragment.AsMessage(
  id: GQL.UUID(),
  content: .AsTextMessageContent(text: "Hello world!").asRootEntityType
)

func foo(_ item: GQL.ConversationItemFragment) {
  guard let message = item.asMessage?.fragments.messageFragment else {
    print("asMessage is broken")
  }
  guard let textContent = message.content.fragments.messageContentFragment.asTextMessageContent else {
    print("asTextMessageContent is broken")
  }
  print("Success \(textContent)")
}

foo(item.asRootEntityType)

It prints asTextMessageContent is broken.

This is because the definition of asTextMessageContent expects some MessageContentFragment.AsTextMessageContent type. But such type is not listed in the __fulfilled set.

  struct MessageContentFragment: GQL.SelectionSet, Fragment {
    var asTextMessageContent: AsTextMessageContent? { _asInlineFragment() }
  }

(lldb) po ObjectIdentifier(GQL.MessageContentFragment.AsTextMessageContent) == ObjectIdentifier(GQL.TextMessageContentFragment)
false

(lldb) po ObjectIdentifier(GQL.MessageContentFragment.AsTextMessageContent) == ObjectIdentifier(GQL.MessageContentFragment)
false

(lldb) po ObjectIdentifier(GQL.MessageContentFragment.AsTextMessageContent) == ObjectIdentifier(GQL.MessageFragment.Content)
false

Logs

No response

Anything else?

No response

[AnthonyMDev]

Thank you for the detailed reproduction case! We'll look into this as soon as we can!

[AnthonyMDev]

The PR that fixes this is now up! Thanks for catching this @tgyhlsb!

We'll have it out in the next patch release. :)