Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the handling of HTTP status codes and Accept graphql-response+json #6079

Closed
martinbonnin opened this issue Jul 26, 2024 · 1 comment

Comments

@martinbonnin
Copy link
Contributor

martinbonnin commented Jul 26, 2024

Description

Currently, we return an error response if the status code is != 2xx. I realized recently that the status codes in the GraphQL over HTTP spec are more for proxies and other links in the chain that do not speak GraphQL than for the client.

Investigate under what conditions we can parse the response and return it to the user (always? Or depending on the returned Content-Type?)

Also add graphql-response+json to the list of accepted content-types.

See https://graphql.github.io/graphql-over-http/draft/#sec-Processing-the-response

@martinbonnin martinbonnin changed the title Clarify the handling of HTTP status code Clarify the handling of HTTP status codes Jul 26, 2024
@martinbonnin martinbonnin changed the title Clarify the handling of HTTP status codes Clarify the handling of HTTP status codes and Accept graphql-response+json Jul 27, 2024
@BoD
Copy link
Contributor

BoD commented Oct 25, 2024

Done with #6170

@BoD BoD closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants