Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async resolve functions do not throw errors if they return undefined #4134

Closed
jer-sen opened this issue May 18, 2020 · 1 comment
Closed
Labels
🍐 error-handling Pertaining to error handling (or lack thereof), not just for just general errors/bugs.

Comments

@jer-sen
Copy link

jer-sen commented May 18, 2020

When allowUndefinedInResolve === false, a resolver should throw an error if it returns undefined. But with an async resolver, no error is thrown.

apollo-server-lambda@2.13.1

@abernix abernix added the 🍐 error-handling Pertaining to error handling (or lack thereof), not just for just general errors/bugs. label Dec 31, 2020
@glasser
Copy link
Member

glasser commented Oct 21, 2022

This option is a parameter to makeExecutableSchema, a function that used to be part of Apollo Server but now is part of the separate graphql-tools project.

Additionally, it looks like this option was removed from graphql-tools last year (not mentioned in PR description but it's in the diff).

@glasser glasser closed this as completed Oct 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🍐 error-handling Pertaining to error handling (or lack thereof), not just for just general errors/bugs.
Projects
None yet
Development

No branches or pull requests

3 participants