generateSchemaHash: changes necessary for graphql@16.0.0 #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
commented
Aug 27, 2021
| const documentAST = parse(introspectionQuery); | ||
| const result = execute(schema, documentAST) as ExecutionResult; | ||
| const document = parse(introspectionQuery); | ||
| const result = execute({ schema, document }) as ExecutionResult<IntrospectionQuery>; |
There was a problem hiding this comment.
Here is the main change: in v16.0.0 we dropped support for positional args to execute.
IvanGoncharov
force-pushed
the
generateSchemaHash
branch
from
d7f7da8
to
7873a4f
Compare
|
Do we need to do what's done in #5663 as well? Or is this just one piece of working towards v16 compatibility? |
glasser
approved these changes
Aug 27, 2021
I update |
|
@IvanGoncharov FYI, I noticed in retrospect that this file didn't have a CHANGELOG entry. Was that intentional, since it doesn't actually get us all the way to graphql 16 compatibility yet? |
|
@glasser Yes, was a partial change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.