Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support type: module with .cjs file extension #2342 #2381

Merged
merged 9 commits into from
Aug 12, 2021
Merged

fix: support type: module with .cjs file extension #2342 #2381

merged 9 commits into from
Aug 12, 2021

Conversation

alexanderniebuhr
Copy link
Contributor

@alexanderniebuhr alexanderniebuhr commented Jul 12, 2021

close #2342

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@apollo-cla
Copy link

@alexanderniebuhr: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@alexanderniebuhr
Copy link
Contributor Author

Not sure why CI Tests fail. Local Tests are passing all

Screenshot 2021-07-12 at 21 40 30

@alexanderniebuhr
Copy link
Contributor Author

@jgzuke just saw you answering PRs and doing heavy work on the transition branch.
If you move the apollo vs code extension, it would be great to get this included asap.

Let me know if you need any more information!

@alexanderniebuhr
Copy link
Contributor Author

@abernix
Copy link
Member

abernix commented Aug 12, 2021

@alexanderniebuhr Thanks for moving that over to the new VS Code repository. Since there are remaining bits in this repository (e.g., the apollo CLI) that also use this file (it's a platform concern), should we re-open this and land this PR?

@abernix abernix reopened this Aug 12, 2021
@abernix
Copy link
Member

abernix commented Aug 12, 2021

Conflicts look like they need to be resolved locally and I believe that all the CI failures are from linting (e.g., a run of prettier via npm run lint-fix)

"lint-fix": "prettier --write \"packages/*/src/**/*.{js,jsx,ts,tsx}\"",

@alexanderniebuhr
Copy link
Contributor Author

@abernix yeah you could reopen this and land it. My main concern was the VS Code Extension, so I just moved it over to the new repo.
I can solve conflicts and run prettier for you

@abernix abernix merged commit 421b214 into apollographql:master Aug 12, 2021
@abernix abernix changed the title fix: support type: module with .cjsfile extension #2342 fix: support type: module with .cjs file extension #2342 Aug 12, 2021
@alexanderniebuhr alexanderniebuhr deleted the patch-1 branch August 12, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension cannot be used it type is set to module
3 participants