You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Attempting to extend a type which isn't defined in any service causes composeAndValidate to throw, which is not a behavior we want. composeAndValidate should capture all composition errors with as much helpful information as possible and return them.
While #478 aimed to address this problem in the first place, resolving this issue should mean that we land a fix which no longer requires the try/catch and discard error approach. These changes should be undone (though the tests can stay and be updated!).
In the weeds a bit:
It's helpful for us to compose as far as we're able to in order to collect as many errors as possible (rather than having the act of composition fail completely with no resulting schema to run validations against). In order to accomplish this in this case, we'll likely need to "create" a false base type to bypass the failure and proceed with composition. This is one option among possible others.
Related: #567
I think tackling these issues simultaneously makes a lot of sense!
The text was updated successfully, but these errors were encountered:
Attempting to
extend
a type which isn't defined in any service causescomposeAndValidate
to throw, which is not a behavior we want.composeAndValidate
should capture all composition errors with as much helpful information as possible and return them.While #478 aimed to address this problem in the first place, resolving this issue should mean that we land a fix which no longer requires the
try/catch
and discard error approach. These changes should be undone (though the tests can stay and be updated!).In the weeds a bit:
It's helpful for us to compose as far as we're able to in order to collect as many errors as possible (rather than having the act of composition fail completely with no resulting schema to run validations against). In order to accomplish this in this case, we'll likely need to "create" a false base type to bypass the failure and proceed with composition. This is one option among possible others.
Related: #567
I think tackling these issues simultaneously makes a lot of sense!
The text was updated successfully, but these errors were encountered: