Skip to content

Commit

Permalink
Rename Boolean (object) type annotations to boolean (primitive).
Browse files Browse the repository at this point in the history
  • Loading branch information
benjamn committed Apr 20, 2018
1 parent e5eb694 commit 169e698
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 12 deletions.
2 changes: 1 addition & 1 deletion src/isEmptyObject.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default function isEmptyObject(obj: Object): Boolean {
export default function isEmptyObject(obj: Object): boolean {
if (!obj) {
return true;
}
Expand Down
2 changes: 1 addition & 1 deletion src/mergeDeep.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ export default function mergeDeep(target: any, source: any): any {
return output;
}

function isObject(item: any): Boolean {
function isObject(item: any): boolean {
return item && typeof item === 'object' && !Array.isArray(item);
}
6 changes: 3 additions & 3 deletions src/stitching/schemaRecreation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import defaultMergedResolver from './defaultMergedResolver';
export function recreateType(
type: GraphQLNamedType,
resolveType: ResolveType<any>,
keepResolvers: Boolean,
keepResolvers: boolean,
): GraphQLNamedType {
if (type instanceof GraphQLObjectType) {
const fields = type.getFields();
Expand Down Expand Up @@ -148,7 +148,7 @@ function parseLiteral(ast: ValueNode): any {
export function fieldMapToFieldConfigMap(
fields: GraphQLFieldMap<any, any>,
resolveType: ResolveType<any>,
keepResolvers: Boolean,
keepResolvers: boolean,
): GraphQLFieldConfigMap<any, any> {
const result: GraphQLFieldConfigMap<any, any> = {};
Object.keys(fields).forEach(name => {
Expand Down Expand Up @@ -195,7 +195,7 @@ export function createResolveType(
export function fieldToFieldConfig(
field: GraphQLField<any, any>,
resolveType: ResolveType<any>,
keepResolvers: Boolean,
keepResolvers: boolean,
): GraphQLFieldConfig<any, any> {
return {
type: resolveType(field.type),
Expand Down
2 changes: 1 addition & 1 deletion src/transforms/FilterRootFields.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export type RootFilter = (
operation: 'Query' | 'Mutation' | 'Subscription',
fieldName: string,
field: GraphQLField<any, any>,
) => Boolean;
) => boolean;

export default class FilterRootFields implements Transform {
private transformer: TransformRootFields;
Expand Down
5 changes: 2 additions & 3 deletions src/transforms/FilterToSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ function filterDocumentToSchema(
const validFragments: Array<FragmentDefinitionNode> = fragments.filter(
(fragment: FragmentDefinitionNode) => {
const typeName = fragment.typeCondition.name.value;
const type = targetSchema.getType(typeName);
return Boolean(type);
return Boolean(targetSchema.getType(typeName));
},
);

Expand Down Expand Up @@ -268,7 +267,7 @@ function resolveType(type: GraphQLType): GraphQLNamedType {
}

function union(...arrays: Array<Array<string>>): Array<string> {
const cache: { [key: string]: Boolean } = {};
const cache: { [key: string]: boolean } = {};
const result: Array<string> = [];
arrays.forEach(array => {
array.forEach(item => {
Expand Down
4 changes: 2 additions & 2 deletions src/transforms/FilterTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import { Transform } from '../transforms/transforms';
import { visitSchema, VisitSchemaKind } from '../transforms/visitSchema';

export default class FilterTypes implements Transform {
private filter: (type: GraphQLNamedType) => Boolean;
private filter: (type: GraphQLNamedType) => boolean;

constructor(filter: (type: GraphQLNamedType) => Boolean) {
constructor(filter: (type: GraphQLNamedType) => boolean) {
this.filter = filter;
}

Expand Down
2 changes: 1 addition & 1 deletion src/transforms/visitSchema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export type TypeVisitor = (
export function visitSchema(
schema: GraphQLSchema,
visitor: SchemaVisitor,
stripResolvers?: Boolean,
stripResolvers?: boolean,
) {
const types = {};
const resolveType = createResolveType(name => {
Expand Down

0 comments on commit 169e698

Please sign in to comment.