Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router should mark fetch spans as error if the downstream response had errors #3123

Closed
BrynCooke opened this issue May 22, 2023 · 1 comment

Comments

@BrynCooke
Copy link
Contributor

Relevant reading:
Semantic conventions for GraphQL: https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/instrumentation/graphql/
Semantic conventions for HTTP https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/http/

https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/plugins/node/opentelemetry-instrumentation-graphql/src/instrumentation.ts#L244-L275

It looks like the node implementation of otel allowed customization of error handling at the execution level.

Full customization will be difficult without some sort of scripting support, but we should make sure we are following the HTTP semantic conventions at the very least.

Let's also add a config option to telemetry to mark fetch spans as errors if they have errors.

@BrynCooke BrynCooke changed the title Router should mark subgraph spans as error if the downstream response had errors Router should mark fetch spans as error if the downstream response had errors May 22, 2023
@chandrikas
Copy link
Contributor

Will be done as part of #3226

@chandrikas chandrikas closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants