Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trace id to log statements even when it is not sampled #4035

Open
kira-u opened this issue Oct 13, 2023 · 1 comment
Open

Add trace id to log statements even when it is not sampled #4035

kira-u opened this issue Oct 13, 2023 · 1 comment
Labels
component/logging component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it. raised by user

Comments

@kira-u
Copy link

kira-u commented Oct 13, 2023

Describe the solution you'd like
Currently, when sampling rate is not 100%, trace_id is not added to logs. It makes impossible to connect logs to individual requests.

Describe alternatives you've considered
Having another "request-id" header moving between services, IMO, is just a duplicate - it would serve the same purpose as trace-id. If request-id and trace-id are different, it makes harder to connect traces with logs.

Maybe I'm not aware of something and there is already a way to achieve the goal?
@BrynCooke
Copy link
Contributor

We're actively looking at this as part of #3226, which is currently in development.

@bnjjj bnjjj mentioned this issue Oct 19, 2023
Open
@bnjjj bnjjj added component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it. component/logging labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/logging component/open-telemetry OTLP, Datadog, Prometheus, etc. and the integrations around it. raised by user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BrynCooke @bnjjj @kira-u