Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching: raise the default Redis timeout #4743

Closed
Geal opened this issue Mar 5, 2024 · 2 comments
Closed

Caching: raise the default Redis timeout #4743

Geal opened this issue Mar 5, 2024 · 2 comments

Comments

@Geal
Copy link
Contributor

Geal commented Mar 5, 2024

It is set to 2ms right now, which is far too low for some users.
https://github.com/apollographql/router/blob/dev/apollo-router/src/cache/redis.rs#L165

They can modify it themselves, but it tends to trip them up. We should set a larger timeout, and let users who want tighter deadlines configure it instead

@theJC
Copy link
Contributor

theJC commented Sep 6, 2024

I believe #5795 addressed this issue

@Geal
Copy link
Contributor Author

Geal commented Sep 6, 2024

You're right, closing this now then

@Geal Geal closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants