Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ease of use: debug mode #5789

Closed
2 tasks
cyberhck opened this issue Aug 8, 2024 · 3 comments · Fixed by #5850
Closed
2 tasks

ease of use: debug mode #5789

cyberhck opened this issue Aug 8, 2024 · 3 comments · Fixed by #5850

Comments

@cyberhck
Copy link
Contributor

cyberhck commented Aug 8, 2024

Currently, if we wanted to use debug (heaptrack) mode on kubernetes, we have few issues:

  • the file it writes to, doesn't have any identifier, so if there are multiple pods, they override the same file
  • There's no easy way to specify that a container shouldn't be restarted inside the pod. (so that we get new pod if the current pod crashes)

Describe alternatives you've considered

  • writing our own charts and forking dockerfile ourselves, but this is unreasonable

If you guys are okay to change this, I'd like to send a PR that:

  • let's user specify pod lifecycle
  • use ${hostname} in the heaptrack file path

Tasks

Preview Give feedback
@BrynCooke
Copy link
Contributor

This all sounds reasonable. @garypen Do you agree?

@cyberhck
Copy link
Contributor Author

if @garypen agrees, I want to create a PR for it.

@garypen
Copy link
Contributor

garypen commented Aug 19, 2024

@cyberhck That seems like a reasonable approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants