Skip to content

Commit

Permalink
Refactor Fs::watch_file to be more async (#2176)
Browse files Browse the repository at this point in the history
Refactors Fs::watch_file to use an async notifier rather than the loop-based approach that it previously used. This is more compatible with the new async runtime we're working towards.

---------

Co-authored-by: Aaron <aaronarinder@gmail.com>
  • Loading branch information
dotdat and aaronArinder committed Sep 26, 2024
1 parent e3702c7 commit 9f8fd80
Show file tree
Hide file tree
Showing 4 changed files with 278 additions and 58 deletions.
2 changes: 2 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ tempfile = "3.8"
tokio = "1.38"
tokio-stream = "0.1"
tokio-test = "0.4.4"
tokio-util = "0.7.12"
toml = "0.8"
tower = { version = "0.5.0", features = ["make", "retry", "timeout"] }
tower-http = "0.5.2"
Expand Down
10 changes: 7 additions & 3 deletions crates/rover-std/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,16 @@ camino = { workspace = true }
console = { workspace = true }
notify = { workspace = true }
notify-debouncer-full = { workspace = true }
tokio = { workspace = true }
tap = { workspace = true }
tokio = { workspace = true, features = [ "macros", "rt", "rt-multi-thread", "time" ] }
tokio-util = { workspace = true}
thiserror = { workspace = true }
tracing = { workspace = true }
url = { workspace = true }

[dev-dependencies]
speculoos = { workspace = true }
notify = { workspace = true }
notify-debouncer-full = { workspace = true }
rstest = { workspace = true }
tempfile = { workspace = true }
speculoos = { workspace = true }
tempfile = { workspace = true }
Loading

0 comments on commit 9f8fd80

Please sign in to comment.