Expose this.visitedType on SchemaDirectiveVisitor instances.

ardatan · Mar 14, 2018 · f951c81 · f951c81
1 parent 7c2dc88
commit f951c81
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/src/directives.ts b/src/directives.ts
@@ -99,6 +99,9 @@ export class SchemaDirectiveVisitor {
   // object, in case a vistor method needs to refer to this.schema.
   public schema: GraphQLSchema;
 
+  // A reference to the type object that this visitor was created to visit.
+  public visitedType: VisitableType;
+
   // Call SchemaDirectiveVisitor.visitSchema(schema, directiveVisitors) to
   // visit every @directive in the schema and instantiate an appropriate
   // SchemaDirectiveVisitor subclass to visit/handle/transform the object
@@ -287,9 +290,12 @@ export class SchemaDirectiveVisitor {
         // created and assigned names. Subclasses can override the constructor
         // method, but since the constructor is marked as protected, these are
         // the only arguments that will ever be passed.
-        directiveInstances.push(
-          new directiveClass({ name, args, schema })
-        );
+        directiveInstances.push(new directiveClass({
+          name,
+          args,
+          visitedType: type,
+          schema
+        }));
       });
 
       return directiveInstances;
@@ -306,10 +312,12 @@ export class SchemaDirectiveVisitor {
   protected constructor(config: {
     name: string,
     args: { [name: string]: any },
+    visitedType: VisitableType,
     schema: GraphQLSchema,
   }) {
     this.name = config.name;
     this.args = config.args;
+    this.visitedType = config.visitedType;
     this.schema = config.schema;
   }
 

diff --git a/src/test/testDirectives.ts b/src/test/testDirectives.ts
@@ -188,6 +188,7 @@ describe('@directives', () => {
       mutationTypeDirective: class extends SchemaDirectiveVisitor {
         public visitObject(object: GraphQLObjectType) {
           mutationObjectType = object;
+          assert.strictEqual(this.visitedType, object);
           assert.strictEqual(object.name, 'Mutation');
         }
       },
@@ -196,6 +197,7 @@ describe('@directives', () => {
         public visitFieldDefinition(field: GraphQLField<any, any>, details: {
           objectType: GraphQLObjectType,
         }) {
+          assert.strictEqual(this.visitedType, field);
           assert.strictEqual(field.name, 'addPerson');
           assert.strictEqual(details.objectType, mutationObjectType);
           assert.strictEqual(field.args.length, 1);
@@ -208,6 +210,7 @@ describe('@directives', () => {
           field: GraphQLField<any, any>,
           objectType: GraphQLObjectType,
         }) {
+          assert.strictEqual(this.visitedType, arg);
           assert.strictEqual(arg.name, 'input');
           assert.strictEqual(details.field, mutationField);
           assert.strictEqual(details.objectType, mutationObjectType);
@@ -217,6 +220,7 @@ describe('@directives', () => {
 
       enumTypeDirective: class extends SchemaDirectiveVisitor {
         public visitEnum(enumType: GraphQLEnumType) {
+          assert.strictEqual(this.visitedType, enumType);
           assert.strictEqual(enumType.name, 'Gender');
           enumObjectType = enumType;
         }
@@ -226,6 +230,7 @@ describe('@directives', () => {
         public visitEnumValue(value: GraphQLEnumValue, details: {
           enumType: GraphQLEnumType,
         }) {
+          assert.strictEqual(this.visitedType, value);
           assert.strictEqual(value.name, 'NONBINARY');
           assert.strictEqual(value.value, 'NONBINARY');
           assert.strictEqual(details.enumType, enumObjectType);
@@ -235,6 +240,7 @@ describe('@directives', () => {
       inputTypeDirective: class extends SchemaDirectiveVisitor {
         public visitInputObject(object: GraphQLInputObjectType) {
           inputObjectType = object;
+          assert.strictEqual(this.visitedType, object);
           assert.strictEqual(object.name, 'PersonInput');
         }
       },
@@ -243,6 +249,7 @@ describe('@directives', () => {
         public visitInputFieldDefinition(field: GraphQLInputField, details: {
           objectType: GraphQLInputObjectType,
         }) {
+          assert.strictEqual(this.visitedType, field);
           assert.strictEqual(field.name, 'name');
           assert.strictEqual(details.objectType, inputObjectType);
         }