Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes: Inconsistencies, usability issues #408

Open
joshuasbates opened this issue May 23, 2018 · 0 comments
Open

Notes: Inconsistencies, usability issues #408

joshuasbates opened this issue May 23, 2018 · 0 comments

Comments

@joshuasbates
Copy link
Contributor

joshuasbates commented May 23, 2018

The Notes component has the following inconsistencies with the current implementation demonstrated in APM using saffron:

  • The component should be rendered in a BlockPanel.
  • When editing a note, the edit control should appear inside the note's `CardBody'. Currently, the entire note card, including the card header, is replaced by the edit view.
  • There is no support for rending the "add" control, which should be rendered inside the block panel (at the top).
  • Various shortcomings of EditableNote:
    • The note data is not provided in the callbacks, so consumers can not track which note is being edited.
    • The edit view should support a "saving" mode for the note so that the button text can reflect the state, and buttons/inputs can be disabled while database actions are in progress.

I have already prototyped and tested changed in the Workflow management components, and will contribute those changes back to react-gears (and update the documentation) in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant