Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up dependencies vs devDependencies #76

Closed
balloob opened this issue Dec 10, 2016 · 1 comment
Closed

Clean up dependencies vs devDependencies #76

balloob opened this issue Dec 10, 2016 · 1 comment

Comments

@balloob
Copy link

balloob commented Dec 10, 2016 •
edited
Loading

Dependencies should only be used for things that are required to be installed when the bundled version is installed. Since we either bundle everything or mark them as external, we should move all dependencies to be either peerDependencies or devDependencies
@balloob balloob mentioned this issue Mar 9, 2017
Closed
@balloob
Copy link
Author

balloob commented Jun 29, 2017

Fixed

@balloob balloob closed this as completed Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@balloob