Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS issue for strike Lookup on IE11 #42

Closed
vimalkarun opened this issue Jul 24, 2017 · 6 comments
Closed

CSS issue for strike Lookup on IE11 #42

vimalkarun opened this issue Jul 24, 2017 · 6 comments
Assignees

Comments

@vimalkarun
Copy link

Strike lookup component is not rendered correctly on IE11.
The component is displayed with Vertical and Horizontal Scroll Bar. The pull down menu for Search result is hidden behind the vertical scroll

image

image

@kevinberonilla kevinberonilla self-assigned this Jul 25, 2017
@kevinberonilla
Copy link
Contributor

Thanks for logging this! It turns out there were some extra classes used on the mobile version of the component that were not conditionally left out. This will be fixed in the next release, but if you need a solution for the current release (0.7.0), you can replace lines 114 and 115 in strike_lookup.cmp with the following code:

            <div class="{!'sl-lookup__input_container' + if(v.isMobile == true, ' slds-grid slds-grid--pull-padded-xx-small', '') + if(and(equals(v.initCallsRunning, 0), empty(v.value)), '', ' slds-hide')}">
                <div class="{!'sl-lookup__input' + if(v.isMobile == true, ' slds-col slds-p-horizontal--xx-small', '')}">

Padding negation using the slds-grid--pull-padded classes was causing the horizontal bar to appear on Edge in cases where the lookup's containing element did not have room for negative margins. Now, these classes are only applied if the v.isMobile internal attribute is set to true.

Please let us know if this solution works for you.

@vimalkarun
Copy link
Author

Thank you for the solution, and now the horizontal scroll is not appearing which is good. but still the search result is hidden behind the vertical scroll.

image

image

@kevinberonilla
Copy link
Contributor

Odd, we'll look into it!

@kevinberonilla
Copy link
Contributor

kevinberonilla commented Jul 27, 2017

Hi @vimalkarun,

Can you try adding the following lines at the end of your CSS file (strike_lookup.css)?

.THIS:not(.sl-lookup--mobile).sl-lookup--open.scrollable {
    overflow: visible;
}

.THIS:not(.sl-lookup--mobile):not(.sl-lookup--open).scrollable {
    overflow: hidden;
}

Additionally, to fix a mobile issue that might be introduced by those rules, you can add the following line in the helper file (strike_lookupHelper.js) above line 150 (before component.set('v.searching', true);).

component.set('v.openMenu', true);

@vimalkarun
Copy link
Author

vimalkarun commented Jul 28, 2017

Cool.. issue is fixed.. :)

Thanks a lot

@kevinberonilla
Copy link
Contributor

If you don't mind, we'd like to keep this issue open until it's actually fixed (when the next release drops, which actually might be today). This is just to help QA keep track of fixes and build changelogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants