Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strike Radio Group - Content inside of Radio Option not closing after selecting a new Radio Option, and then not reopening #90

Closed
justinAppiphony opened this issue Oct 2, 2017 · 3 comments

Comments

@justinAppiphony
Copy link

Hi,

I brought the default live code from the fiddler page for Strike Radio Group to a Flexipage/Lightning Record page by placing it inside a wrapper. It appears on the page just fine, however when I switch between radio options, it seems as if the content inside is not closing upon clicking a new radio option, and when it does, navigating back to the radio option with content inside does not open.

Walk-through -

  1. Enter code in developer console

<aura:component implements="force:appHostable,flexipage:availableForAllPageTypes" access="global">
<c:strike_radioGroup
value="radio-option-2"
label="Radio Group Label">
<c:strike_input label="Radio Option 1" value="radio-option-1"/>
<c:strike_radioGroupContent
showWhenValueEquals="radio-option-1">
<aura:set attribute="content">
<lightning:select
name="Select Name"
label="Select label"
value="option-1"
variant="standard">
Option 1
Option 2
Option 3
</lightning:select>
</aura:set>
</c:strike_radioGroupContent>
<c:strike_input label="Radio Option 2" value="radio-option-2"/>
<c:strike_radioGroupContent
showWhenValueEquals="radio-option-2">
<aura:set attribute="content">
<lightning:input
name="Input Name"
type="checkbox"
label="Checked">
</lightning:input>
</aura:set>
</c:strike_radioGroupContent>
<c:strike_input label="Radio Option 3" value="radio-option-3"/>
</c:strike_radioGroup>
</aura:component>

  1. Navigate back to the Lightning page and refresh page
    image

  2. Select Option 1 and note the content inside (this will stay open when selecting a different radio option in the next step
    image

  3. Select Radio Option 2 - The content inside of Radio Option 1 stays open
    image

  4. Select Radio Option 3 - Now Radio Option 1 content closes
    image

  5. Note that upon reselecting Radio Option 1 again, the content inside does not open
    image

@daneowens3
Copy link
Contributor

I was able to alleviate this issue by calling "selectRadioButtonFromValue" from "handleClickRadio" as "selectRadioButtonFromValue" was only being called once after render.

@justinAppiphony
Copy link
Author

Thank you @daneowens3 !

@daneowens3
Copy link
Contributor

This has been addressed and should be resolved next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants