feat: Drop older screenshoting APIs #721
Conversation
mykola-mokhnach
changed the title
| } | ||
| }); | ||
| if (!isHeicSuppported) { | ||
| [FBLogger logFmt:@"The device under test does not support HEIC image encoding. Falling back to PNG"]; |
There was a problem hiding this comment.
@KazuCocoa Could you please check how this validation behaves on real devices?
There was a problem hiding this comment.
Yes, of course. Potentially it will be late a bit, but will do
There was a problem hiding this comment.
Maybe I can do this tonight in PT
There was a problem hiding this comment.
The behavior seems good to me.
We should update xcuitest driver's default screenshotQuality value and the capability's description after this. I haven't verified OOM related stuff with my devices, so hopefully this will help the memory usage as addressed in the description
| @@ -10,6 +10,8 @@ | |||
| #import <Foundation/Foundation.h> | |||
| #import <CoreGraphics/CoreGraphics.h> | |||
|
|
|||
| @class UTType; | |||
There was a problem hiding this comment.
Just a note:
This type has worked since iOS 14. We no longer support the version, but current WDA can work with iOS 13. So after this version, such a lower version completely does not work as incompatible code while can compile and install to lower iOS version such as iOS 12 and 13.
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I have also set the default screenshoting quality to 3, which abbreviates Apple HEIC image encoder.
This is a lossless format, which gives much better quality results being converted to PNG and it also ensures decent compression level, which helps to avoid unexpected memory issues on devices with larger screens