Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add log to leave it in the system log #772

Merged
merged 1 commit into from
Sep 21, 2023
Merged

chore: add log to leave it in the system log #772

merged 1 commit into from
Sep 21, 2023

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Sep 21, 2023

I observed that handleCreateSession took 1 minute, but usually, it was in a few seconds.

Not clear the cause but maybe that was by

+ (instancetype)fb_applicationWithPID:(pid_t)processID
{
if (0 == processID) {
return nil;
}
return [self applicationWithPID:processID];
}
(so os side's something I guess), but it was not clear.

(called by

FBApplication *application = [FBApplication fb_applicationWithPID:appElement.processIdentifier];
)

For future logging, i'd like to leave a message in currentCapabilities, used the last part of handleCreateSession after getting the activeApplication here (to see log message when that was resolved.)

@KazuCocoa KazuCocoa merged commit 012af21 into master Sep 21, 2023
40 of 45 checks passed
@KazuCocoa KazuCocoa deleted the log branch September 21, 2023 23:38
github-actions bot pushed a commit that referenced this pull request Sep 21, 2023
## [5.8.6](v5.8.5...v5.8.6) (2023-09-21)

### Miscellaneous Chores

* add log to leave it in the system log ([#772](#772)) ([012af21](012af21))
@github-actions
Copy link

🎉 This PR is included in version 5.8.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants