Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build error with type of xmldom #428

Merged
merged 3 commits into from
Sep 13, 2024
Merged

fix: build error with type of xmldom #428

merged 3 commits into from
Sep 13, 2024

Conversation

KazuCocoa
Copy link
Member

The same as appium/appium#20537

@KazuCocoa KazuCocoa changed the title fix: build error with type fix: build error with type of xmldom Sep 13, 2024
package.json Outdated
@@ -44,7 +44,7 @@
"dependencies": {
"@appium/base-driver": "^9.1.0",
"@appium/support": "^5.1.1",
"@xmldom/xmldom": "^0.x",
"@xmldom/xmldom": "^0.9.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we need this as such pattern only includes patches for version 0.9

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea. hm, at least this won't hurt smaller versions so let me keep x here

@KazuCocoa KazuCocoa merged commit 0c3838f into master Sep 13, 2024
6 checks passed
@KazuCocoa KazuCocoa deleted the fix-build-error branch September 13, 2024 13:50
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
## [5.6.76](v5.6.75...v5.6.76) (2024-09-13)

### Bug Fixes

* build error with type of xmldom ([#428](#428)) ([0c3838f](0c3838f))
Copy link
Contributor

🎉 This PR is included in version 5.6.76 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants