Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set animation scale via settings for api level 26+ #1007

Merged
merged 12 commits into from
May 28, 2024
Merged

chore: set animation scale via settings for api level 26+ #1007

merged 12 commits into from
May 28, 2024

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented May 25, 2024 •
edited
Loading

appium/appium-adb#745 method instead of --no-window-animation for espresso since the flag in espresso instrumentation process did not bring the animation scale back after the process kill.

0/1 for animation scale is to make the behavior as same as this.settingsApp.setAnimationState

@KazuCocoa KazuCocoa requested a review from mykola-mokhnach May 25, 2024 07:07
@KazuCocoa KazuCocoa mentioned this pull request May 25, 2024
Merged
@KazuCocoa
Copy link
Member Author

hm, this option didn't bring back to animation on after the process end.

Below worked on real devices, thus we may need to do this.

$ adb shell settings put global window_animation_scale 1
$ adb shell settings put global transition_animation_scale 1
$ adb shell settings put global animator_duration_scale 1

@KazuCocoa KazuCocoa marked this pull request as draft May 25, 2024 07:55
@KazuCocoa KazuCocoa changed the title chore: use --no-window-animation to disable animation for api level 26+ chore: set animation scale via settings for api level 26+ May 25, 2024
@KazuCocoa KazuCocoa mentioned this pull request May 25, 2024
Merged
@KazuCocoa KazuCocoa marked this pull request as ready for review May 26, 2024 07:47
@KazuCocoa KazuCocoa requested a review from jlipps May 26, 2024 18:06
mykola-mokhnach
mykola-mokhnach reviewed May 26, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
mykola-mokhnach
mykola-mokhnach reviewed May 26, 2024
View reviewed changes
lib/driver.ts Outdated Show resolved Hide resolved
KazuCocoa
KazuCocoa commented May 27, 2024
View reviewed changes
package.json Show resolved Hide resolved
@KazuCocoa KazuCocoa changed the title chore: set animation scale via settings for api level 26+ feat: set animation scale via settings for api level 26+ May 27, 2024
@KazuCocoa KazuCocoa requested a review from mykola-mokhnach May 27, 2024 15:12
@mykola-mokhnach
Copy link
Contributor

actually it would be just a type chore change

@KazuCocoa KazuCocoa changed the title feat: set animation scale via settings for api level 26+ chore: set animation scale via settings for api level 26+ May 28, 2024
@KazuCocoa KazuCocoa merged commit 5dec6be into master May 28, 2024
12 checks passed
@KazuCocoa KazuCocoa deleted the animation branch May 28, 2024 02:58
github-actions bot pushed a commit that referenced this pull request May 28, 2024
@semantic-release-bot
chore(release): 2.40.2 [skip ci]
a2e2632 
## [2.40.2](v2.40.1...v2.40.2) (2024-05-28)

### Miscellaneous Chores

* set animation scale via settings for api level 26+ ([#1007](#1007)) ([5dec6be](5dec6be))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.40.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

@jlipps jlipps Awaiting requested review from jlipps

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KazuCocoa @mykola-mokhnach