Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable screenshots and hierarchy snapshots on failures #895

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

mykola-mokhnach
Copy link
Contributor

Similar to #894, but should also work for earlier Espresso versions

@mykola-mokhnach mykola-mokhnach marked this pull request as ready for review August 7, 2023 11:28
@mykola-mokhnach
Copy link
Contributor Author

@pr4bh4sh Would this one work for you?

@pr4bh4sh
Copy link
Contributor

pr4bh4sh commented Aug 7, 2023

@mykola-mokhnach This will work thanks.

@mykola-mokhnach mykola-mokhnach requested a review from jlipps August 7, 2023 16:30
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@@ -98,6 +102,11 @@ object Server : NanoHTTPD(DEFAULT_PORT) {
router = Router()
}

private fun setCustomFailureHandler() =
Espresso.setFailureHandler(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡

@mykola-mokhnach mykola-mokhnach merged commit 40bd4a7 into appium:master Aug 7, 2023
@mykola-mokhnach mykola-mokhnach deleted the failure_handler branch August 7, 2023 17:01
github-actions bot pushed a commit that referenced this pull request Aug 7, 2023
## [2.25.0](v2.24.0...v2.25.0) (2023-08-07)

### Features

* Disable screenshots and hierarchy snapshots on failures ([#895](#895)) ([40bd4a7](40bd4a7))
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 2.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants