Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update arguments validation in several mobile extensions #948

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

mykola-mokhnach
Copy link
Contributor

Selenium binding implicitly mutates element argument values and we don't want this to happen, so I renamed it to elementId, like it was already done in UIA2.
Also dropped the single validate.js import used for a single method args validation and implemented the validation myself

@mykola-mokhnach mykola-mokhnach merged commit f90118f into appium:master Nov 3, 2023
12 checks passed
@mykola-mokhnach mykola-mokhnach deleted the validate branch November 3, 2023 19:36
github-actions bot pushed a commit that referenced this pull request Nov 3, 2023
## [2.29.0](v2.28.2...v2.29.0) (2023-11-03)

### Features

* Add support of UiModeManager service commands ([#947](#947)) ([320e0ac](320e0ac))

### Miscellaneous Chores

* Update arguments validation in several mobile extensions ([#948](#948)) ([f90118f](f90118f))
Copy link

github-actions bot commented Nov 3, 2023

🎉 This PR is included in version 2.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants