Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Import the proper support module #964

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

mykola-mokhnach
Copy link
Contributor

No description provided.

@mykola-mokhnach mykola-mokhnach merged commit e9afc21 into appium:master Jan 7, 2024
11 of 12 checks passed
@mykola-mokhnach mykola-mokhnach deleted the support_imp branch January 7, 2024 19:01
github-actions bot pushed a commit that referenced this pull request Jan 7, 2024
## [2.32.1](v2.32.0...v2.32.1) (2024-01-07)

### Bug Fixes

* Import the proper support module ([#964](#964)) ([e9afc21](e9afc21))
Copy link

github-actions bot commented Jan 7, 2024

🎉 This PR is included in version 2.32.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jlipps
Copy link
Member

jlipps commented Jan 10, 2024

Are we sure we want to do this? Previously we had migrated all such imports to appium/support so that only one version of @appium/support was used: the one inside the Appium peer dep. If we need something that's not yet in appium/support, maybe the better strategy is to increase the Appium peer dep version requirement?

@mykola-mokhnach
Copy link
Contributor Author

to appium/support so that only one version of @appium/support was used

This is exactly what was done. Not sure what your question is about

@jlipps
Copy link
Member

jlipps commented Jan 11, 2024

🤦 i read the diff backwards. sorry, no issue here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants