Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawable and Lifecycle issues fix (#449) #506

Closed
wants to merge 1 commit into from

Conversation

uterator
Copy link

@uterator uterator commented Oct 31, 2019

The change has been done based on #449 discussions.
It addresses the errors with Drawable and Lifecycle

@jsf-clabot
Copy link

jsf-clabot commented Oct 31, 2019

CLA assistant check
All committers have signed the CLA.

@uterator uterator changed the title Drawable and Lifecycle issues (#449) Drawable and Lifecycle issues fix (#449) Oct 31, 2019
@mykola-mokhnach
Copy link
Contributor

@dpgraham Do you have any ideas about what happened to PointerDispatchTest? Is it just flaky?

@mykola-mokhnach
Copy link
Contributor

@uterator Thanks for the PR

Do you know why https://dev.azure.com/AppiumCI/Appium%20CI/_build/results?buildId=6145 fails with java.lang.NoClassDefFoundError: Failed resolution of: Lcom/google/android/material/navigation/NavigationView; error? It looks like this error is caused by the changes done in the PR

@dpgraham
Copy link
Contributor

@mykola-mokhnach I'll look at it over the weekend. I need to get Espresso Driver and Appium Desktop sorted out.

@dpgraham
Copy link
Contributor

@mykola-mokhnach yeah you're right actually, I think it's from the PR.

Thanks for submitting this @uterator@ Do you know why this would happen ^ (java.lang.NoClassDefFoundError: Failed resolution of: Lcom/google/android/material/navigation/NavigationView)

@KazuCocoa
Copy link
Member

Perhaps the below? It has a dependency to NavigationView

androidTestImplementation("androidx.test.espresso:espresso-contrib:$espresso_version") {
    transitive = false
}

@mykola-mokhnach
Copy link
Contributor

@uterator Is there any chance to fix the PR?

@uterator
Copy link
Author

@uterator Is there any chance to fix the PR?

Hi @mykola-mokhnach, I haven't check yet but actually I don't have a good idea how to fix that. At this moment I can't put time on it so if someone can have a look on it it will be great help.

@blane1988
Copy link

Any updates to this?

@grzegorz-jarosz
Copy link
Contributor

Builds are to old now to see the logs, but when I tried this fix few days ago I had to add
androidTestImplementation 'com.google.android.material:material:1.2.0'
To have navigation tests working.

@mykola-mokhnach
Copy link
Contributor

@grzegorz-jarosz Could you please raise a new PR with this fix included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants