Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add password rule for appleloan.citizensbank.com #821

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Add password rule for appleloan.citizensbank.com #821

merged 1 commit into from
Sep 17, 2024

Conversation

calebd
Copy link
Collaborator

@calebd calebd commented Sep 16, 2024

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

Password Guidelines

erynofwales
erynofwales approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@erynofwales erynofwales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rmondello rmondello merged commit b494668 into apple:main Sep 17, 2024
5 checks passed
rmondello pushed a commit to rmondello/password-manager-resources that referenced this pull request Nov 6, 2024
@calebd @rmondello
Add password rule for appleloan.citizensbank.com. (apple#821)
3836504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmmaslenn dmmaslenn dmmaslenn approved these changes

@jmulani jmulani jmulani approved these changes

@aabosh aabosh aabosh approved these changes

@Sameesunkaria Sameesunkaria Sameesunkaria approved these changes

@erynofwales erynofwales erynofwales approved these changes

@rmondello rmondello rmondello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@calebd @rmondello @erynofwales @Sameesunkaria @aabosh @jmulani @dmmaslenn