Add missing available annotation to streaming tests #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czechboy0
approved these changes
Nov 27, 2023
Signed-off-by: Si Beaumont <beaumont@apple.com>
simonjbeaumont
force-pushed
the
sb/fix-test-availability-annotation
branch
from
2a02b7c
to
d92b4fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The tests had a missing
@availableannotation which meant that they didn't build iOS (annoyingly, when building for macOS, these things are not checked so things were building fine locally).Modifications
Add missing available annotation to streaming tests.
Result
Builds for iOS again.
Test Plan
Local testing, selecting generic iOS destination in Xcode. This failed before this patch, and succeeds with it.