Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit dependency on HTTPTypes #39

Merged

Conversation

czechboy0
Copy link
Collaborator

@czechboy0 czechboy0 commented Nov 30, 2023

Motivation

Recent SwiftPM versions seem to be a bit stricter about using (i.e., import ...) transitive dependencies without explicitly declaring them as direct dependencies.

Modifications

Explicitly depend on the HTTPTypes module from swift-http-types.

Result

More explicitly declare the dependency graph.

Test Plan

All tests pass.

@czechboy0 czechboy0 changed the title Experiment: an explicit dependency on HTTPTypes Explicit dependency on HTTPTypes Dec 1, 2023
@czechboy0 czechboy0 marked this pull request as ready for review December 1, 2023 07:16
@czechboy0
Copy link
Collaborator Author

@swift-server-bot test this please

Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems clearly correct, and a good catch. It's a shame we broke downstreams on this and I'd love for us to quickly explore if we can add anything to our CI that would catch this? Is there any compiler flag that would catch this at all?

@czechboy0
Copy link
Collaborator Author

I'm not aware of any, and I'm not even positive that this is needed. It's a somewhat speculative and defensive change.

@czechboy0 czechboy0 merged commit 4290b2c into apple:main Dec 1, 2023
5 checks passed
@czechboy0 czechboy0 deleted the hd-experiment-explicit-dependency-http-types branch December 1, 2023 12:36
@czechboy0 czechboy0 added the semver/patch No public API change. label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants