-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to use release 5.10 image #47
Conversation
@swift-server-bot add to allowlist |
5.10 is failing because strict concurrency checking and warnings as errors are enabled. The concurrency checking emits a warning because of the generated test file which contains a static array of test classes, and Do you have a preference for which option to disable? |
Sorry, misread your message. Yeah, not sure. @briancroom what's the recommendation here? |
I thought I'd check the runtime and generator repos for precedence here and found that we have disabled strict-concurrency in one and warnings-as-errors in the other 🤦. Ideally we'd disable neither but don't have a strong opinion about the stopgap solution. Let's make sure we file an issue to cover getting back to belt-and-braces. The longer it's disabled, the harder it's gonna be to enable again. //cc @czechboy0 |
I disabled strict concurrency checking for now and filed #49 to re-enable it. I also filed a radar against SwiftPM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @glbrntt!
No description provided.