Fix request and response translation #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks great, thank you @guoye-zhang! Do you think we can extend the tests to cover the different delimiter appending logic based? |
|
I updated the test with multiple values. |
simonjbeaumont
approved these changes
Jul 2, 2024
|
@swift-server-bot test this please |
czechboy0
approved these changes
Jul 3, 2024
|
@swift-server-bot add to allowlist |
|
The failed CI is a transitive infra issue, rekicking. |
|
@swift-server-bot test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix the translation between Foundation types and HTTP types.
Modifications
The code is mostly borrowed from swift-http-types:
https://github.com/apple/swift-http-types/tree/main/Sources/HTTPTypesFoundation
Translates the string encoding (URLSession expects ISOLatin1) and handles multi-value fields.
Result
Should address the cookie issue among other issues.
Test Plan
All existing tests still pass.