Recore deprecated SwiftSyntaxParser on top of SwiftParser. #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops the dependency on the `_InternalSwiftSyntaxParser` library, and the entire C++ parser/AST/libSyntax stack.
|
@swift-ci please test |
|
@swift-ci please test |
benlangmuir
reviewed
Sep 10, 2022
| @@ -2,73 +2,10 @@ | |||
|
|
|||
| ## Create release tag | |||
| 1. Check out the tag you want to release in the SwiftSyntax repository | |||
There was a problem hiding this comment.
This section only contains a "checkout" step at this point, which doesn't really correspond to the title "Create release tag".
| ## Smoke test on macOS | ||
|
|
||
| 1. Change the binary target in `Package.swift` to point to your personal GitHub repo | ||
| 2. Open the SwiftSyntax package with an Xcode version that contains no or an incompatible parser library | ||
| 3. Update to Latest Package Versions in Xcode | ||
| 2. Update to Latest Package Versions in Xcode | ||
| 4. Run tests |
|
This is rebased by #1041 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the dependency on the
_InternalSwiftSyntaxParserlibrary, and the entire C++ parser/AST/libSyntax stack.