-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining Swift 5.10 support. #467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please test |
Holding until Swift Package Manager is able to support packages requiring Swift 6. |
@swift-ci please test |
@finestructure Would you mind reviewing this PR? I know there's no SPI-specific changes in it, but just in case you see something here that might cause issues. |
Swift Testing has been accepted into Swift 6. For more information, see [here](https://forums.swift.org/t/accepted-a-new-direction-for-testing-in-swift/72309). This PR removes all remaining support for the Swift 5.10 toolchain. The package now requires Swift 6.
96a4f05
to
3004600
Compare
@swift-ci please test |
finestructure
approved these changes
Jun 12, 2024
@swift-ci please test |
stmontgomery
approved these changes
Jun 12, 2024
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Jun 13, 2024
Swift testing recently dropped support for Swift 5.10 in swiftlang/swift-testing#467 Our tests were only runing swift-testing tests in 6.0 and up, but the test project was configured to include it as a dependency with 5.10. Bump this up to 6.0.
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Jun 13, 2024
Swift testing recently dropped support for Swift 5.10 in swiftlang/swift-testing#467 Our tests were only runing swift-testing tests in 6.0 and up, but the test project was configured to include it as a dependency with 5.10. Bump this up to 6.0.
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Jun 14, 2024
Swift testing recently dropped support for Swift 5.10 in swiftlang/swift-testing#467 Our tests were only runing swift-testing tests in 6.0 and up, but the test project was configured to include it as a dependency with 5.10. Bump this up to 6.0.
adam-fowler
pushed a commit
to swiftlang/vscode-swift
that referenced
this pull request
Jun 14, 2024
Swift testing recently dropped support for Swift 5.10 in swiftlang/swift-testing#467 Our tests were only runing swift-testing tests in 6.0 and up, but the test project was configured to include it as a dependency with 5.10. Bump this up to 6.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
public-api
Affects public API
swift-6
Swift 6 issues
tools integration
Integration of swift-testing into tools/IDEs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift Testing has been accepted into Swift 6. For more information, see here.
This PR removes all remaining support for the Swift 5.10 toolchain. The package now requires Swift 6.
Checklist: