Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining Swift 5.10 support. #467

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Jun 10, 2024

Swift Testing has been accepted into Swift 6. For more information, see here.

This PR removes all remaining support for the Swift 5.10 toolchain. The package now requires Swift 6.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added tools integration Integration of swift-testing into tools/IDEs public-api Affects public API swift-6 Swift 6 issues labels Jun 10, 2024
@grynspan grynspan self-assigned this Jun 10, 2024
@grynspan
Copy link
Contributor Author

@swift-ci please test

2 similar comments
@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan
Copy link
Contributor Author

Holding until Swift Package Manager is able to support packages requiring Swift 6.

@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan
Copy link
Contributor Author

@finestructure Would you mind reviewing this PR? I know there's no SPI-specific changes in it, but just in case you see something here that might cause issues.

@grynspan grynspan force-pushed the jgrynspan/remove-5.10-support branch from 96a4f05 to 3004600 Compare June 12, 2024 13:05
@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan
Copy link
Contributor Author

@swift-ci please test

@grynspan grynspan merged commit 8edb08f into main Jun 12, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/remove-5.10-support branch June 12, 2024 16:06
plemarquand added a commit to plemarquand/vscode-swift that referenced this pull request Jun 13, 2024
Swift testing recently dropped support for Swift 5.10 in
swiftlang/swift-testing#467

Our tests were only runing swift-testing tests in 6.0 and up, but the
test project was configured to include it as a dependency with 5.10.
Bump this up to 6.0.
plemarquand added a commit to plemarquand/vscode-swift that referenced this pull request Jun 13, 2024
Swift testing recently dropped support for Swift 5.10 in
swiftlang/swift-testing#467

Our tests were only runing swift-testing tests in 6.0 and up, but the
test project was configured to include it as a dependency with 5.10.
Bump this up to 6.0.
plemarquand added a commit to plemarquand/vscode-swift that referenced this pull request Jun 14, 2024
Swift testing recently dropped support for Swift 5.10 in
swiftlang/swift-testing#467

Our tests were only runing swift-testing tests in 6.0 and up, but the
test project was configured to include it as a dependency with 5.10.
Bump this up to 6.0.
adam-fowler pushed a commit to swiftlang/vscode-swift that referenced this pull request Jun 14, 2024
Swift testing recently dropped support for Swift 5.10 in
swiftlang/swift-testing#467

Our tests were only runing swift-testing tests in 6.0 and up, but the
test project was configured to include it as a dependency with 5.10.
Bump this up to 6.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
public-api Affects public API swift-6 Swift 6 issues tools integration Integration of swift-testing into tools/IDEs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants