Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications are not getting sent when gorush kept idle for long time #693

Closed
sankethkini opened this issue Sep 20, 2022 · 3 comments
Closed
Labels

Comments

@sankethkini
Copy link

Hello @appleboy,

We have observed that after keeping gorush idle for a long time (10-12hrs), the gorush is not sending the notifications. Its accepting the POST /api/push request and sending 200 response code. By logs I can see that its adding the requests into the queue (we are using redis) but the RunFunc(notify.Run(cfg)) is not getting called. When we restart the pod RunFunc(notify.Run(cfg)) of all the requests which are in the queue is getting called at once. Kindly help us to resolve the issue.

version: 1.15
queue: redis

@appleboy
Copy link
Owner

@sankethkini OK. I will take it.

@appleboy appleboy added the bug label Oct 29, 2022
@sankethkini
Copy link
Author

hey @appleboy I have fixed the issue for my usecase kindly see the pr
golang-queue/redisdb-stream#15

@appleboy
Copy link
Owner

@sankethkini Please help to try the master version. I will bump the new version if ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants