Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy algorithm support #56

Closed
abdelhamid-attaby opened this issue May 23, 2020 · 21 comments · Fixed by #57
Closed

Legacy algorithm support #56

abdelhamid-attaby opened this issue May 23, 2020 · 21 comments · Fixed by #57
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@abdelhamid-attaby
Copy link

I got the following message when trying to ssh a BlueHost server:

2020/05/23 13:43:07 ssh: handshake failed: ssh: no common algorithm for key exchange; client offered: [curve25519-sha256@libssh.org ecdh-sha2-nistp256 ecdh-sha2-nistp384 ecdh-sha2-nistp521 diffie-hellman-group14-sha1], server offered: [diffie-hellman-group-exchange-sha256]

Even when I try ssh-action@v0.0.9.

@appleboy
Copy link
Owner

related to issue appleboy/scp-action#15

@abdelhamid-attaby Can you provide detailed steps about how to generate the ssh key?

@appleboy
Copy link
Owner

Add the algorithm to your client config:

  1. open /etc/ssh/ssh_config
  2. update KexAlgorithms setting and add diffie-hellman-group-exchange-sha256

@abdelhamid-attaby
Copy link
Author

@appleboy I generated the key using the Manage SSH Keys in cPanel.

@abdelhamid-attaby
Copy link
Author

abdelhamid-attaby commented May 23, 2020

Add the algorithm to your client config:

  1. open /etc/ssh/ssh_config
  2. update KexAlgorithms setting and add diffie-hellman-group-exchange-sha256

Which client config, I am using Github Actions.

@appleboy
Copy link
Owner

@abdelhamid-attaby Can you login to your server via ssh?

@abdelhamid-attaby
Copy link
Author

@appleboy Yes I can using a downloaded private key.

@abdelhamid-attaby
Copy link
Author

abdelhamid-attaby commented May 23, 2020

@appleboy any idea? The KexAlgorithm should be added to the compiled ubuntu image of the ssh-action.

@appleboy
Copy link
Owner

@abdelhamid-attaby I will take it.

@abdelhamid-attaby
Copy link
Author

@appleboy Thanks

@appleboy
Copy link
Owner

@abdelhamid-attaby Please help to try https://github.com/appleboy/ssh-action/releases/tag/v0.1.0 version and give me feedback.

@abdelhamid-attaby
Copy link
Author

@appleboy same here 🙁

@appleboy
Copy link
Owner

appleboy commented May 24, 2020

@abdelhamid-attaby Please add the following:

use_insecure_cipher: true

see https://github.com/appleboy/ssh-action#input-variables

@abdelhamid-attaby
Copy link
Author

@abdelhamid-attaby Please add the following:

use_insecure_cipher: true

see https://github.com/appleboy/ssh-action#input-variables

@appleboy same


2020/05/24 03:06:24 ssh: handshake failed: ssh: no common algorithm for key exchange; client offered: [curve25519-sha256@libssh.org ecdh-sha2-nistp256 ecdh-sha2-nistp384 ecdh-sha2-nistp521 diffie-hellman-group14-sha1], server offered: [diffie-hellman-group-exchange-sha256]

@appleboy appleboy reopened this May 24, 2020
@appleboy
Copy link
Owner

@abdelhamid-attaby Please help to try the master version

uses: appleboy/ssh-action@master

@appleboy appleboy added the enhancement New feature or request label May 24, 2020
@appleboy appleboy self-assigned this May 24, 2020
@abdelhamid-attaby
Copy link
Author

@appleboy same

@appleboy
Copy link
Owner

@abdelhamid-attaby Can you post your config?

@abdelhamid-attaby
Copy link
Author

@abdelhamid-attaby Can you post your config?


name: Deploy to Prod
on:
  push:
    branches: 
      - master
jobs:
  Deploy-To-Dev:
    name: Build and Deploy
    runs-on: ubuntu-latest
    steps:
    - name: executing remote ssh commands using key
      uses: appleboy/ssh-action@master
      with:
        host: coligotech.com
        username: coligote
        key: ${{ secrets.KEY }}
        passphrase: ${{ secrets.PASSPHRASE }}
        use_insecure_cipher: true

        script: |
          cd public_html/almoultka
          git checkout master
          git pull

@appleboy
Copy link
Owner

@abdelhamid-attaby

Please re-run again and make sure the image cache layer.

chore__update_to_latest_version_·_appleboy_ssh-action_1cb5cd3

@abdelhamid-attaby
Copy link
Author

@appleboy worked now 👌. Thanks a lot 🙏. It is an amazing action by the way.

@appleboy
Copy link
Owner

@abdelhamid-attaby I will bump the new version. Thanks for your testing.

@appleboy
Copy link
Owner

@appleboy appleboy removed the enhancement New feature or request label May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants