Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificate health checker #636

Merged
merged 1 commit into from
Dec 26, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions chart/stash/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ The following table lists the configurable parameters of the Stash chart and the
| `apiserver.disableStatusSubresource` | If true, disables status sub resource for crds. Otherwise enables based on Kubernetes version | `false` |
| `apiserver.bypassValidatingWebhookXray` | If true, bypasses validating webhook xray checks | `false` |
| `apiserver.useKubeapiserverFqdnForAks` | If true, uses kube-apiserver FQDN for AKS cluster to workaround https://github.com/Azure/AKS/issues/522 | `true` |
| `apiserver.healthcheck.enabled` | Enable readiness and liveliness probes | `true` |
| `enableAnalytics` | Send usage events to Google Analytics | `true` |
| `monitoring.agent` | Specify which monitoring agent to use for monitoring Stash. It accepts either `prometheus.io/builtin` or `prometheus.io/coreos-operator`. | `none` |
| `monitoring.backup` | Specify whether to monitor Stash backup and recovery. | `false` |
Expand Down
9 changes: 9 additions & 0 deletions chart/stash/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,20 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
{{- if .Values.apiserver.healthcheck.enabled }}
readinessProbe:
httpGet:
path: /healthz
port: 8443
scheme: HTTPS
initialDelaySeconds: 5
livenessProbe:
httpGet:
path: /healthz
port: 8443
scheme: HTTPS
initialDelaySeconds: 5
{{- end }}
resources:
requests:
cpu: "100m"
Expand Down
3 changes: 3 additions & 0 deletions chart/stash/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ apiserver:
bypassValidatingWebhookXray: false
# If true, uses kube-apiserver FQDN for AKS cluster to workaround https://github.com/Azure/AKS/issues/522 (default true)
useKubeapiserverFqdnForAks: true
# healthcheck configures the readiness and liveliness probes for the operator pod.
healthcheck:
enabled: true

# Send usage events to Google Analytics
enableAnalytics: true
Expand Down
16 changes: 8 additions & 8 deletions glide.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion glide.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ import:
version: v1.1.1
- package: github.com/evanphx/json-patch
version: v3.0.0
- package: github.com/go-ini/ini
version: v1.40.0
- package: github.com/go-openapi/spec
- package: github.com/golang/glog
- package: github.com/golang/protobuf
Expand All @@ -45,6 +47,8 @@ import:
version: 1.1.5
- package: github.com/mailru/easyjson
version: 2f5df55504ebc322e4d52d34df6a1f5b503bf26d
- package: github.com/mitchellh/mapstructure
version: v1.1.2
- package: github.com/ncw/swift
version: master
- package: github.com/onsi/ginkgo
Expand Down Expand Up @@ -74,7 +78,7 @@ import:
- package: google.golang.org/api/storage/v1
version: 3639d6d93f377f39a1de765fa4ef37b3c7ca8bd9
- package: gopkg.in/ini.v1
version: v1.37.0
version: v1.40.0
- package: gopkg.in/robfig/cron.v2
repo: https://github.com/appscode/cron.git
vcs: git
Expand Down
7 changes: 7 additions & 0 deletions hack/deploy/operator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,13 @@ spec:
path: /healthz
port: 8443
scheme: HTTPS
initialDelaySeconds: 5
livenessProbe:
httpGet:
path: /healthz
port: 8443
scheme: HTTPS
initialDelaySeconds: 5
- name: pushgateway
args:
- --web.listen-address=:56789
Expand Down
2 changes: 1 addition & 1 deletion vendor/github.com/go-ini/ini/LICENSE

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading