From 2a7b097a7179e1212b175530bd04a7abe6380c48 Mon Sep 17 00:00:00 2001 From: Tom de Bruijn Date: Mon, 23 Sep 2019 21:38:27 +0200 Subject: [PATCH] Remove honor_cipher_order option A new hackney version has been released which no longer sets `honor_cipher_order` to `true` by default. This means we can remove our workaround. Make sure to upgrade hackney for AppSignal to work. --- lib/appsignal/transmitter.ex | 3 +-- mix_helpers.exs | 3 +-- test/appsignal/transmitter_test.exs | 4 ++-- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/appsignal/transmitter.ex b/lib/appsignal/transmitter.ex index 06739e365..fe761787c 100644 --- a/lib/appsignal/transmitter.ex +++ b/lib/appsignal/transmitter.ex @@ -18,8 +18,7 @@ defmodule Appsignal.Transmitter do [ ssl_options: [ cacertfile: ca_file_path, - ciphers: ciphers(), - honor_cipher_order: :undefined + ciphers: ciphers() ] ]} diff --git a/mix_helpers.exs b/mix_helpers.exs index 6db9dc345..169883b5d 100644 --- a/mix_helpers.exs +++ b/mix_helpers.exs @@ -190,8 +190,7 @@ defmodule Mix.Appsignal.Helper do options = [ ssl_options: [ cacertfile: priv_path("cacert.pem"), - ciphers: ciphers(), - honor_cipher_order: :undefined + ciphers: ciphers() ] ] diff --git a/test/appsignal/transmitter_test.exs b/test/appsignal/transmitter_test.exs index 012324287..1c37c64fa 100644 --- a/test/appsignal/transmitter_test.exs +++ b/test/appsignal/transmitter_test.exs @@ -20,7 +20,7 @@ defmodule Appsignal.TransmitterTest do _url, _headers, _body, - [ssl_options: [cacertfile: ^path, ciphers: _, honor_cipher_order: :undefined]] + [ssl_options: [cacertfile: ^path, ciphers: _]] ] = Transmitter.request(:get, "https://example.com") end @@ -33,7 +33,7 @@ defmodule Appsignal.TransmitterTest do _url, _headers, _body, - [ssl_options: [cacertfile: ^path, ciphers: _, honor_cipher_order: :undefined]] + [ssl_options: [cacertfile: ^path, ciphers: _]] ] = Transmitter.request(:get, "https://example.com") end) end