feat: add htmlPageTitle hook and use it in login and sign up pages

appsmithorg · Jun 14, 2023 · 3639a5a · 3639a5a
1 parent 29b2554
commit 3639a5a
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/app/client/src/ce/pages/UserAuth/Login.tsx b/app/client/src/ce/pages/UserAuth/Login.tsx
@@ -46,6 +46,8 @@ import {
   getThirdPartyAuths,
   getIsFormLoginEnabled,
 } from "@appsmith/selectors/tenantSelectors";
+import Helmet from "react-helmet";
+import { useHtmlPageTitle } from "@appsmith/utils";
 
 const validate = (values: LoginFormValues, props: ValidateProps) => {
   const errors: LoginFormValues = {};
@@ -86,6 +88,7 @@ export function Login(props: LoginFormProps) {
   const isFormLoginEnabled = useSelector(getIsFormLoginEnabled);
   const socialLoginList = useSelector(getThirdPartyAuths);
   const queryParams = new URLSearchParams(location.search);
+  const htmlPageTitle = useHtmlPageTitle();
   const invalidCredsForgotPasswordLinkText = createMessage(
     LOGIN_PAGE_INVALID_CREDS_FORGOT_PASSWORD_LINK,
   );
@@ -133,6 +136,10 @@ export function Login(props: LoginFormProps) {
       subtitle={createMessage(LOGIN_PAGE_SUBTITLE)}
       title={createMessage(LOGIN_PAGE_TITLE)}
     >
+      <Helmet>
+        <title>{htmlPageTitle}</title>
+      </Helmet>
+
       {showError && (
         <Callout
           kind="error"

diff --git a/app/client/src/ce/pages/UserAuth/SignUp.tsx b/app/client/src/ce/pages/UserAuth/SignUp.tsx
@@ -47,6 +47,8 @@ import {
   getIsFormLoginEnabled,
   getThirdPartyAuths,
 } from "@appsmith/selectors/tenantSelectors";
+import Helmet from "react-helmet";
+import { useHtmlPageTitle } from "@appsmith/utils";
 
 declare global {
   interface Window {
@@ -93,6 +95,7 @@ export function SignUp(props: SignUpFormProps) {
   const socialLoginList = useSelector(getThirdPartyAuths);
   const shouldDisableSignupButton = pristine || !isFormValid;
   const location = useLocation();
+  const htmlPageTitle = useHtmlPageTitle();
 
   const recaptchaStatus = useScript(
     `https://www.google.com/recaptcha/api.js?render=${googleRecaptchaSiteKey.apiKey}`,
@@ -166,6 +169,10 @@ export function SignUp(props: SignUpFormProps) {
       subtitle={createMessage(SIGNUP_PAGE_SUBTITLE)}
       title={createMessage(SIGNUP_PAGE_TITLE)}
     >
+      <Helmet>
+        <title>{htmlPageTitle}</title>
+      </Helmet>
+
       {showError && <Callout kind="error">{errorMessage}</Callout>}
       {socialLoginList.length > 0 && (
         <ThirdPartyAuth logins={socialLoginList} type={"SIGNUP"} />

diff --git a/app/client/src/ce/utils/index.ts b/app/client/src/ce/utils/index.ts
@@ -9,3 +9,7 @@ export const addItemsInContextMenu = (
 ) => {
   return moreActionItems;
 };
+
+export const useHtmlPageTitle = () => {
+  return "Appsmith";
+};