Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dropping currency widget on to list widget causes app to crash #10683

Closed
1 task done
ramsaptami opened this issue Jan 27, 2022 · 8 comments
Closed
1 task done
Assignees
Labels
Bug Something isn't working Currency Input Widget Issues related to currency input widget High This issue blocks a user from building or impacts a lot of users List Widget Issues related to the list widget Production Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets

Comments

@ramsaptami
Copy link
Contributor

ramsaptami commented Jan 27, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Drag and drop a currency widget onto a list widget and observe the app crash and be unable to load the app if the widget is on the home page

Steps To Reproduce

LOOM DEMO

Environment

Production

Version

Cloud

@ramsaptami ramsaptami added Bug Something isn't working Critical This issue needs immediate attention. Drop everything else Production Needs Triaging Needs attention from maintainers to triage List Widget Issues related to the list widget Currency Input Widget Issues related to currency input widget labels Jan 27, 2022
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets UI Building Pod labels Jan 27, 2022
@somangshu
Copy link
Contributor

@sbalaji1192 could you take a look at this?

@sbalaji1192
Copy link
Contributor

sbalaji1192 commented Feb 7, 2022

Widgets with derived property/meta property won't work well inside the list widget, hence We are going to restrict those widgets from being added in the List widget canvas. List of widgets that are allowed -

"AUDIO_WIDGET",
"BUTTON_GROUP_WIDGET",
"BUTTON_WIDGET",
"CHART_WIDGET",
"CHECKBOX_WIDGET",
"CHECKBOX_GROUP_WIDGET",
"CIRCULAR_PROGRESS_WIDGET",
"DIVIDER_WIDGET",
"ICON_BUTTON_WIDGET",
"IFRAME_WIDGET",
"IMAGE_WIDGET",
"INPUT_WIDGET_V2",
"MAP_CHART_WIDGET",
"MAP_WIDGET",
"MENU_BUTTON_WIDGET",
"PROGRESSBAR_WIDGET",
"STATBOX_WIDGET",
"SWITCH_WIDGET",
"SWITCH_GROUP_WIDGET",
"TEXT_WIDGET",
"VIDEO_WIDGET",

@sbalaji1192
Copy link
Contributor

sbalaji1192 commented Feb 8, 2022

RCA of the original issue: The currency widget and Phone input widget updates meta property(countryCode) when it gets mounted. List widget changes its children's id to list-widget-child-id-${itemIndex}-${widgetName}. when updating the meta property we're sending this id instead of the original Id and this id is supposed to be only used by the list widget, hence the platform is not recognizing this and we end up with an invalid canvas widget state, as a result, App crashes. The above solution to restrict widgets with meta property from being dropped inside the list widget should solve this issue.

@sbalaji1192
Copy link
Contributor

fixed as part of #10928

@sbalaji1192 sbalaji1192 added QA Needs QA attention and removed Needs Triaging Needs attention from maintainers to triage labels Feb 9, 2022
@YogeshJayaseelan YogeshJayaseelan added Verified When issue is retested post its fixed and removed QA Needs QA attention labels Feb 9, 2022
@dilippitchika dilippitchika added High This issue blocks a user from building or impacts a lot of users and removed Critical This issue needs immediate attention. Drop everything else labels Mar 24, 2022
@dilippitchika
Copy link
Contributor

dilippitchika commented Mar 24, 2022

@sbalaji1192 reopening this issue, but with a lower priority. We can still drop blacklisted widgets by dragging them into the canvas first and then dropping them into the list

loom -
LOOM DEMO

CC @somangshu

@dilippitchika dilippitchika reopened this Mar 24, 2022
@sbalaji1192
Copy link
Contributor

@dilippitchika I did discuss this with @riodeuno . There is an open story to address this issue - #10659 . Lets close this and track this over there

@dilippitchika
Copy link
Contributor

Got it, could you please add a note/update the issue #10659, it's not very understandable for non-developers

@riodeuno
Copy link
Contributor

@dilippitchika I have updated the task details in #10659 However, it is still quite technical in the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Currency Input Widget Issues related to currency input widget High This issue blocks a user from building or impacts a lot of users List Widget Issues related to the list widget Production Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets
Projects
None yet
Development

No branches or pull requests

6 participants