Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Navigating to custom widget's "Edit Source" crashes page if module instance is present #35462

Closed
1 task done
ApekshaBhosale opened this issue Aug 6, 2024 · 0 comments · Fixed by #35463
Closed
1 task done

[Bug]: Navigating to custom widget's "Edit Source" crashes page if module instance is present #35462

ApekshaBhosale opened this issue Aug 6, 2024 · 0 comments · Fixed by #35463
Assignees
@Nikhil-Nandagopal @pranavkanade
Labels
Bug Something isn't working Critical This issue needs immediate attention. Drop everything else High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Production QA Needs QA attention

Comments

@ApekshaBhosale
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Navigating to custom widget's "Edit Source" crashes page if module instance is present as it doesn't get currentPageId

Steps To Reproduce

  1. create an app
  2. create a query module and publish it
  3. go back to app
  4. add custom widget
  5. add query module
  6. go to custom widget
  7. click on widget and click on "edit source"
  8. app crash

Public Sample App

No response

Environment

Production

Severity

Critical (Broken Production apps)

Issue video log

No response

Version

Cloud
@ApekshaBhosale ApekshaBhosale added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Aug 6, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Critical This issue needs immediate attention. Drop everything else High This issue blocks a user from building or impacts a lot of users Production labels Aug 6, 2024
@brayn003 brayn003 mentioned this issue Aug 6, 2024
Merged
2 tasks
@appsmith-bot appsmith-bot added the QA Needs QA attention label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nikhil-Nandagopal Nikhil-Nandagopal

@pranavkanade pranavkanade

Labels
Bug Something isn't working Critical This issue needs immediate attention. Drop everything else High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Production QA Needs QA attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: issue with opening custom widget source editor appsmithorg/appsmith
4 participants
@Nikhil-Nandagopal @ApekshaBhosale @pranavkanade @appsmith-bot