Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition when unpausing MCP at the end of a noop-for-pool maintenance #120

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fix race condition when unpausing MCP at the end of a noop-for-pool maintenance #120

merged 1 commit into from
Nov 15, 2024

Commits on Nov 15, 2024

  1. Fix race condition when unpausing MCP at the end of a noop-for-pool m… 

    …aintenance

The previous version was able to get into an invalid state: the upgrade job was updated twice ([1][1], [2][2]) at the end of an update and the k8s client cache does not guarantee read after write consistency [3][3]. This lead to the MCPs being paused again just after force unpausing them.

[1]: https://github.com/appuio/openshift-upgrade-controller/blob/0c1b407fd99a17ada4242a6454303911938377cd/controllers/upgradejob_controller.go#L939
[2]: https://github.com/appuio/openshift-upgrade-controller/blob/0c1b407fd99a17ada4242a6454303911938377cd/controllers/upgradejob_controller.go#L334
[3]: https://pkg.go.dev/sigs.k8s.io/controller-runtime#hdr-Clients_and_Caches
    @bastjan
    bastjan committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    db4cf5a View commit details
    Browse the repository at this point in the history