Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: some confirmation dialogs appear out of screen #466

Closed
2 tasks done
melnibon opened this issue Jun 22, 2023 · 3 comments
Closed
2 tasks done

🐛 Bug Report: some confirmation dialogs appear out of screen #466

melnibon opened this issue Jun 22, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@melnibon
Copy link

👟 Reproduction steps

When I click on some Delete buttons (APIkeys, users, collections...), their confirmation dialogs appear out of the screen, at least partially, making it impossible to click on buttons. And it is not possible to scroll to make the dialogs appear.

Inspecting the HTML and CSS, it looks like a CSS rule, @layer the-new-css-reset { does not include the <dialog> tag. When I manually add dialog, to the list, it works as expected.

:where(:not(html,
 dialog,
 iframe,
 canvas,
...

👍 Expected behavior

The dialogs should be centered on the screen, or at least, all their content must be accessible.

👎 Actual Behavior

Dialogs are truncated or invisible. This picture shows the bottom of my browser window:
Capture d’écran du 2023-06-22 15-27-24

🎲 Appwrite version

Version 1.3.x

💻 Operating system

Linux

🧱 Your Environment

Self-hosted Appwrite 1.3.7

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@melnibon melnibon added the bug Something isn't working label Jun 22, 2023
@joeyouss
Copy link

Hi
Thank you for opening this.
I tried reproducing and seems like it is centered for me.
Screenshot 2023-06-27 at 4 28 41 PM

Kindly allow me to investigate about this more as to why this might be happening, this could be environment specific. Can you let me know what is the browser you are using?

@joeyouss joeyouss self-assigned this Jun 27, 2023
@melnibon
Copy link
Author

Hello Jyoti,
Thank you for your reply. Yes, it is surely related to my environment.

I tried on Windows, with Firefox 114.0.2 and Edge: it works perfectly. But on Debian, with Firefox 102.12.0esr, dialog boxes are not centered.

It has to do with this CSS rule:

@layer the-new-css-reset {
 *:where(:not(html,
 iframe,
 canvas,
 img,
 svg,
 video,
 audio):not(svg *,
 symbol *)) {
  all:unset;
  display:revert
 }

When I deactivate the all:unset rule (in the dev console) or when I add dialog to the where list, dialogs appear centered. There a a lot of items under all:unset, so I cannot determine which one is failing on my Firefox.

Ok this is not a question of Appwrite but on my specific version of Firefox. I can edit the rule until next update of my Firefox. So I close this ticket. Sorry for the worries.

Many thanks for your work on Appwrite

@joeyouss
Copy link

joeyouss commented Jul 3, 2023

Good to know, thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants