Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: use type hints #61

Closed
2 tasks done
Ananya2001-an opened this issue Jun 9, 2023 · 0 comments
Closed
2 tasks done

🚀 Feature: use type hints #61

Ananya2001-an opened this issue Jun 9, 2023 · 0 comments

Comments

@Ananya2001-an
Copy link

🔖 Feature description

In python we don't have strict type checking like in TS but we can still add type hints which would be good for better readability and maintainability. Also we can use a famous python package called mypy to implement some strict type checking if possible; not a necessity tho :)

🎤 Pitch

Like maybe something like this:

def get_image(self, url, width: float = None, height: float = None) -> Optional[str]:

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant