Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oauth return location header #768

Merged
merged 51 commits into from
Feb 24, 2024
Merged

Conversation

loks0n
Copy link
Member

@loks0n loks0n commented Feb 5, 2024

We want to allow server-side SDKs to use webAuth type endpoints such as createOAuth2Session and createOAuth2Token.

These endpoints should return the string value of the location header on server SDKs.

for example:

const redirectUrl = await account.createOAuth2Token("github", successUrl, failureUrl);`

console.log(redirectUrl) // outputs: https://github.com/oauth2?query=asdkfjhasdkjfhasdhkf?....
  • Node
  • Deno
  • Kotlin
  • Dart
  • DotNet
  • PHP
  • Python
  • Ruby
  • Swift

@loks0n loks0n requested a review from Meldiron February 5, 2024 13:01
@loks0n loks0n changed the base branch from master to 1.5.x February 5, 2024 13:01
@loks0n loks0n closed this Feb 20, 2024
@loks0n loks0n reopened this Feb 20, 2024
@loks0n loks0n requested a review from abnegate February 21, 2024 10:34
src/SDK/Language/Kotlin.php Show resolved Hide resolved
src/SDK/Language/Swift.php Outdated Show resolved Hide resolved
templates/swift/base/requests/oauth.twig Outdated Show resolved Hide resolved
@abnegate abnegate merged commit 38119c7 into 1.5.x Feb 24, 2024
34 checks passed
@abnegate abnegate deleted the feat-oauth-return-location-header branch February 24, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants