[tf/gcp] add dns support for GCP testnet #8160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sionescu
approved these changes
May 11, 2023
rustielin
force-pushed
the
rustielin/gcp-testnet-dns
branch
from
b1673c1 to
2a17897
Compare
sionescu
approved these changes
May 17, 2023
terraform/aptos-node/gcp/dns.tf
Outdated
| @@ -56,9 +56,9 @@ resource "google_dns_record_set" "fullnode" { | |||
| } | |||
|
|
|||
| output "validator_endpoint" { | |||
| value = var.zone_name != "" ? "/dns4/${trimsuffix(google_dns_record_set.validator[0].name, ".")}/tcp/${data.kubernetes_service.validator-lb[0].spec[0].port[0].port}" : null | |||
| value = var.zone_name != "" && var.create_records ? "/dns4/${trimsuffix(google_dns_record_set.validator[0].name, ".")}/tcp/${data.kubernetes_service.validator-lb[0].spec[0].port[0].port}" : null | |||
There was a problem hiding this comment.
This access path seems error prone if the service isnt present?
There was a problem hiding this comment.
yea we're kinda making the assumption that the k8s services come up without issue. no way around this imo since we're still coupling infra and application release. At least it will fail with a good error
perryjrandall
approved these changes
May 17, 2023
geekflyer
reviewed
May 17, 2023
| @@ -29,6 +29,9 @@ module "validator" { | |||
| zone_name = var.zone_name # keep empty if you don't want a DNS name | |||
| zone_project = var.zone_project | |||
| record_name = var.record_name | |||
| # do not create the main fullnode and validator DNS records | |||
| # instead, rely on external-dns from the testnet-addons | |||
| create_records = false | |||
There was a problem hiding this comment.
let's call this create_dns_records for clarity
rustielin
force-pushed
the
rustielin/gcp-testnet-dns
branch
from
2a17897 to
472083e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add variable
var.create_dns_recordsto control whether or not to create validator and fullnode specific DNS records directly on the first validator. These are only really useful in the case of deploying just a single validator/VFN, since there's 2 records that need to be created (one for validator and one for fullnode). It's simpler to create the record directly in TF rather than using an external dependency like external-dns.Since we're hosting a bunch of validators and fullnodes for testnets, we'd want each one to have a DNS name. That's a use case for external-dns. So in testnets, set
create_dns_records = false, and let external-dns handle the restTest Plan
Lint & apply, unblocking new devnet GCP deployment