This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
Move file patterns to a higher level to be able to use it on any analyzer #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knqyf263 could you please take a look? |
3 similar comments
|
@knqyf263 could you please take a look? |
|
@knqyf263 could you please take a look? |
|
@knqyf263 could you please take a look? |
jerbob92
force-pushed
the
feature/move-file-patterns-to-global
branch
from
36954cf
to
7fd46a7
Compare
|
@knqyf263 I have updated the MR to the latest version of Fanal |
|
@knqyf263 for how long do I have to maintain this MR until it gets merged? |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the file patterns feature from the config analyzers to a global level so that we can use it on any analyzer.
In favor of #370, #357, #355 as this feature will allow you to set the needed file patterns yourself.
This also makes the config analyzers more like the other analyzers.
We talked about asking the community, but IMHO it makes sense to just add it as it is a logical next step after having it in the config analyzers.
This can be enabled in Trivy without changing anything to the config scanner. The other commands will just get a
--filter-patternsoption, I already have a branch for that ready.What do you think @knqyf263?